Skip to content

4174 only read indats using the indat class - #4523

Draft
clmould wants to merge 6 commits into
mainfrom
4174-only-read-indats-using-the-indat-class
Draft

4174 only read indats using the indat class#4523
clmould wants to merge 6 commits into
mainfrom
4174-only-read-indats-using-the-indat-class

Conversation

@clmould

@clmould clmould commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

  • Moves validate_input to the InDat class and rename to check_obsolete_variables
  • parse_input_file no longer re-reads the file line by line
  • Removes tests/integration/data/ref_IN.DAT as this was too outdated and couldn't be updated, and instead uses large_tokamake_IN.DAT for test_write_new_in_dat -> the test passes on main since all the obsolete lines are skipped, however we should be using up to date files in tests otherwise this isn't a very good test
  • Fix PLR1702 errors in these files

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Aug 13, 2026 that may be closed by this pull request
Only read IN.DATs using the InDat class #4174
Open
2 tasks
@clmould
clmould force-pushed the 4174-only-read-indats-using-the-indat-class branch from bc34539 to eda15dc Compare August 13, 2026 16:26
@clmould clmould mentioned this pull request Aug 14, 2026
Open
2 tasks
@clmould
clmould force-pushed the 4174-only-read-indats-using-the-indat-class branch 3 times, most recently from 72a627d to e8a494b Compare August 27, 2026 13:14
@clmould
clmould force-pushed the 4174-only-read-indats-using-the-indat-class branch 5 times, most recently from 7dbf2d0 to 9816a42 Compare September 2, 2026 12:27
@clmould
clmould force-pushed the 4174-only-read-indats-using-the-indat-class branch from 9816a42 to d4d920c Compare September 2, 2026 12:47
@codecov-commenter

codecov-commenter commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.45902% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.87%. Comparing base (8dde8cd) to head (1def96a).

Files with missing lines Patch % Lines
process/core/io/in_dat/base.py 44.23% 29 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4523      +/-   ##
==========================================
+ Coverage   49.85%   49.87%   +0.02%     
==========================================
  Files         151      151              
  Lines       29876    29881       +5     
==========================================
+ Hits        14894    14903       +9     
+ Misses      14982    14978       -4

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Only read IN.DATs using the InDat class

2 participants

@clmould @codecov-commenter